-
Notifications
You must be signed in to change notification settings - Fork 379
feat: add custom events support #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fadi-george
merged 6 commits into
rel/5.3-beta
from
fadi/sdk-2947-add-custom-events-for-react-native-package
Oct 1, 2025
Merged
feat: add custom events support #1838
fadi-george
merged 6 commits into
rel/5.3-beta
from
fadi/sdk-2947-add-custom-events-for-react-native-package
Oct 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add android track event method expose ios trackEvent method
update min version of ios fix android & ios example
sherwinski
approved these changes
Sep 29, 2025
nan-li
requested changes
Sep 29, 2025
Contributor
|
Do not merge to main |
5eb8b84 to
70d188c
Compare
nan-li
reviewed
Sep 30, 2025
android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java
Outdated
Show resolved
Hide resolved
da43fed to
087efef
Compare
087efef to
456a302
Compare
927617e to
f1a5cc3
Compare
nan-li
reviewed
Oct 1, 2025
android/src/main/java/com/onesignal/rnonesignalandroid/RNUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/onesignal/rnonesignalandroid/RNUtils.java
Outdated
Show resolved
Hide resolved
fe04bdf to
7f19633
Compare
7f19633 to
17c5156
Compare
nan-li
approved these changes
Oct 1, 2025
nan-li
requested changes
Oct 1, 2025
Contributor
nan-li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but blocking until the base of the PR changes
nan-li
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Details
RNOneSignal.javaRCTOneSignalEventEmitter.msrc/index.tstrackEventdemo action for the example projectMotivation
Code change is to allow developers to use custom-events with the react-native package.
Testing
Manual testing
Run ios and android emulators and tested the
trackEventaction. See screenshot of the custom event actually being recorded.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is